Skip to content

[MCP] Improve [Parameter] XML doc comments — Group G: Feedback & Display#4828

Merged
vnbaaij merged 7 commits into
microsoft:dev-v5from
AClerbois:users/aclerbois/dev-v5/fix-mcp-docs-group-g
May 18, 2026
Merged

[MCP] Improve [Parameter] XML doc comments — Group G: Feedback & Display#4828
vnbaaij merged 7 commits into
microsoft:dev-v5from
AClerbois:users/aclerbois/dev-v5/fix-mcp-docs-group-g

Conversation

@AClerbois

Copy link
Copy Markdown
Collaborator

Summary

Improves XML doc comments on [Parameter] properties in feedback and display components so the MCP server serves accurate descriptions to AI models.

Components

Component Key Fixes
FluentProgressBar / FluentSpinner Thickness name/description mismatch, swapped CSS cross-refs
FluentSkeleton Shimmer ambiguous with Visible, grammar issues
FluentRatingDisplay Critical: class summary was copy-pasted verbatim from FluentProgressBar
FluentSlider Min said "minimal" (not a valid description), ImmediateDelay grammar
FluentDatePicker / FluentTimePicker / FluentCalendar Icon same description as Appearance, empty summaries on several props

Part of

Part of #4777

Copilot AI review requested due to automatic review settings May 5, 2026 19:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates C# XML doc comments for [Parameter] properties across several Feedback & Display components so the MCP server returns clearer, less ambiguous parameter descriptions to AI tooling.

Changes:

  • Adds inline usage examples (e.g., <c>Min="0"</c>) and cross-references (<see cref="..."/>) to key parameters in Slider and Progress components.
  • Clarifies parameter semantics and reduces ambiguity in Skeleton, RatingDisplay, and Calendar/DatePicker/TimePicker components.
  • Fixes incorrect/copy-pasted summaries (notably FluentRatingDisplay).

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/Core/Components/Slider/FluentSlider.razor.cs Improves Min/Max/ImmediateDelay summaries with examples and cross-references.
src/Core/Components/Skeleton/FluentSkeleton.razor.cs Clarifies Shimmer vs Visible, Circular behavior, and Pattern guidance.
src/Core/Components/RatingDisplay/FluentRatingDisplay.razor.cs Replaces incorrect class summary and strengthens parameter summaries with examples.
src/Core/Components/Progress/FluentSpinner.razor.cs Clarifies AppearanceInverted parameter intent and adds an inline usage example.
src/Core/Components/Progress/FluentProgressBar.razor.cs Improves Min/Max/Value/Color/Thickness summaries and adds examples/cross-links.
src/Core/Components/DateTime/FluentTimePicker.razor.cs Documents RenderStyle, clarifies DisabledTimeFunc, and refines StartHour/EndHour summaries.
src/Core/Components/DateTime/FluentDatePicker.razor.cs Fixes Icon vs Appearance summary mismatch and documents RenderStyle.
src/Core/Components/DateTime/FluentCalendar.razor.cs Fixes typos/wording and clarifies SelectMode and SelectDatesHover behavior.

Comment thread src/Core/Components/RatingDisplay/FluentRatingDisplay.razor.cs Outdated
Comment thread src/Core/Components/DateTime/FluentDatePicker.razor.cs Outdated
Comment thread src/Core/Components/Skeleton/FluentSkeleton.razor.cs Outdated
Comment thread src/Core/Components/Skeleton/FluentSkeleton.razor.cs Outdated
Comment thread src/Core/Components/DateTime/FluentCalendar.razor.cs Outdated
@AClerbois AClerbois force-pushed the users/aclerbois/dev-v5/fix-mcp-docs-group-g branch 2 times, most recently from b6469d6 to deb2174 Compare May 18, 2026 17:27
AClerbois added a commit to AClerbois/fluentui-blazor that referenced this pull request May 18, 2026
…Feedback & Display)

- Remove non-compilable MyIcons example from FluentRatingDisplay.Shape doc
- Remove internal CoreIcons reference from FluentDatePicker.Icon doc
- Fix FluentSkeleton.Circular doc: parameters are not mutated, styles are computed
- Add missing period to FluentSkeleton.Pattern first sentence
- Fix "Years view" -> "Years views" grammar in FluentCalendar

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
AClerbois and others added 6 commits May 18, 2026 21:55
…Feedback & Display)

- Remove non-compilable MyIcons example from FluentRatingDisplay.Shape doc
- Remove internal CoreIcons reference from FluentDatePicker.Icon doc
- Fix FluentSkeleton.Circular doc: parameters are not mutated, styles are computed
- Add missing period to FluentSkeleton.Pattern first sentence
- Fix "Years view" -> "Years views" grammar in FluentCalendar

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@AClerbois AClerbois force-pushed the users/aclerbois/dev-v5/fix-mcp-docs-group-g branch from 661da9b to 518e1a7 Compare May 18, 2026 19:55
@vnbaaij vnbaaij enabled auto-merge (squash) May 18, 2026 20:51
@vnbaaij vnbaaij merged commit 6f30999 into microsoft:dev-v5 May 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants