[MCP] Improve [Parameter] XML doc comments — Group G: Feedback & Display#4828
Merged
vnbaaij merged 7 commits intoMay 18, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates C# XML doc comments for [Parameter] properties across several Feedback & Display components so the MCP server returns clearer, less ambiguous parameter descriptions to AI tooling.
Changes:
- Adds inline usage examples (e.g.,
<c>Min="0"</c>) and cross-references (<see cref="..."/>) to key parameters in Slider and Progress components. - Clarifies parameter semantics and reduces ambiguity in Skeleton, RatingDisplay, and Calendar/DatePicker/TimePicker components.
- Fixes incorrect/copy-pasted summaries (notably
FluentRatingDisplay).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Core/Components/Slider/FluentSlider.razor.cs | Improves Min/Max/ImmediateDelay summaries with examples and cross-references. |
| src/Core/Components/Skeleton/FluentSkeleton.razor.cs | Clarifies Shimmer vs Visible, Circular behavior, and Pattern guidance. |
| src/Core/Components/RatingDisplay/FluentRatingDisplay.razor.cs | Replaces incorrect class summary and strengthens parameter summaries with examples. |
| src/Core/Components/Progress/FluentSpinner.razor.cs | Clarifies AppearanceInverted parameter intent and adds an inline usage example. |
| src/Core/Components/Progress/FluentProgressBar.razor.cs | Improves Min/Max/Value/Color/Thickness summaries and adds examples/cross-links. |
| src/Core/Components/DateTime/FluentTimePicker.razor.cs | Documents RenderStyle, clarifies DisabledTimeFunc, and refines StartHour/EndHour summaries. |
| src/Core/Components/DateTime/FluentDatePicker.razor.cs | Fixes Icon vs Appearance summary mismatch and documents RenderStyle. |
| src/Core/Components/DateTime/FluentCalendar.razor.cs | Fixes typos/wording and clarifies SelectMode and SelectDatesHover behavior. |
b6469d6 to
deb2174
Compare
AClerbois
added a commit
to AClerbois/fluentui-blazor
that referenced
this pull request
May 18, 2026
…Feedback & Display) - Remove non-compilable MyIcons example from FluentRatingDisplay.Shape doc - Remove internal CoreIcons reference from FluentDatePicker.Icon doc - Fix FluentSkeleton.Circular doc: parameters are not mutated, styles are computed - Add missing period to FluentSkeleton.Pattern first sentence - Fix "Years view" -> "Years views" grammar in FluentCalendar Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…Feedback & Display) - Remove non-compilable MyIcons example from FluentRatingDisplay.Shape doc - Remove internal CoreIcons reference from FluentDatePicker.Icon doc - Fix FluentSkeleton.Circular doc: parameters are not mutated, styles are computed - Add missing period to FluentSkeleton.Pattern first sentence - Fix "Years view" -> "Years views" grammar in FluentCalendar Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
661da9b to
518e1a7
Compare
vnbaaij
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves XML doc comments on
[Parameter]properties in feedback and display components so the MCP server serves accurate descriptions to AI models.Components
Thicknessname/description mismatch, swapped CSS cross-refsShimmerambiguous withVisible, grammar issuesFluentProgressBarMinsaid "minimal" (not a valid description),ImmediateDelaygrammarIconsame description asAppearance, empty summaries on several propsPart of
Part of #4777